Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/react: allow React 19 as peer dependency #5556

Merged
merged 4 commits into from
Dec 18, 2024
Merged

@uppy/react: allow React 19 as peer dependency #5556

merged 4 commits into from
Dec 18, 2024
+2 −2

Conversation

djshubs
Copy link
Contributor

@djshubs djshubs commented Dec 17, 2024 •
edited
Loading

Dep update for React 19

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Diff output files 
No diff

The following build files have been modified and might affect the actual diff:

yarn.lock

@socket-security Socket Security
Copy link

socket-security bot commented Dec 17, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@djshubs djshubs requested a review from Murderlon December 17, 2024 21:29
@Murderlon Murderlon changed the title build: update peer dep for @uppy/react to react 19 @uppy/react: allow React 19 as peer dependency Dec 18, 2024
@Murderlon Murderlon merged commit d6156bb into transloadit:main Dec 18, 2024
5 checks passed
@djshubs djshubs deleted the react-19 branch December 19, 2024 09:54
@jamalsoueidan
Copy link

npm install @uppy/react

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: cv-editor-router@undefined
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^19.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.0.0" from @uppy/[email protected]
npm ERR! node_modules/@uppy/react
npm ERR! @uppy/react@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
pending end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djshubs @jamalsoueidan @Murderlon